Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RC version in the go.mod file cannot be retrieved #525

Open
2 of 5 tasks
sonatard opened this issue Dec 27, 2024 · 2 comments
Open
2 of 5 tasks

The RC version in the go.mod file cannot be retrieved #525

sonatard opened this issue Dec 27, 2024 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@sonatard
Copy link

sonatard commented Dec 27, 2024

Description:

RC is not included in the scope of the regular expression

const match = contents.match(/^go (\d+(\.\d+)*)/m);

Action version:
Specify the action version

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
Go 1.24rc1

Repro steps:

// go.mod
go 1.24rc1
    - uses: actions/setup-go@v5
      with:
        go-version-file: ./go.mod
        cache: false

Expected behavior:

Setup go version spec 1.24rc1
Attempting to download 1.24rc1...
matching 1.24rc1...

Actual behavior:

Setup go version spec 1.24
Attempting to download 1.24...
matching 1.24...
@sonatard sonatard added bug Something isn't working needs triage labels Dec 27, 2024
@mahalakshmi-rekadi
Copy link

Hello @sonatard,
Thank you for creating this issue. We will investigate it and provide feedback as soon as we have some updates.

@priyagupta108 priyagupta108 self-assigned this Dec 27, 2024
@priyagupta108
Copy link
Contributor

Hi @sonatard,
Thank you for bringing this issue to our attention. After analyzing the issue, we have confirmed that the regular expression does not include RC versions, causing the Go version specified in go.mod to be improperly matched.
To mitigate this, you can specify pre-release versions using the go-version input within the setup-go action.

We will investigate this further and explore the possibility of incorporating support for RC versions in the go.mod file.

We will consider this as a potential feature request for future improvements. In the meantime, please feel free to share any further insights or suggestions you may have.

@priyagupta108 priyagupta108 removed their assignment Jan 3, 2025
@priyagupta108 priyagupta108 added feature request New feature or request to improve the current logic and removed bug Something isn't working labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants