Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A crash during compression will lose all data #47

Open
aliddell opened this issue Jan 27, 2023 · 1 comment
Open

A crash during compression will lose all data #47

aliddell opened this issue Jan 27, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@aliddell
Copy link
Member

Kyle pointed this out in the chunking RFC document. If we're accumulating to a buffer while we compress and then crash in the middle of accumulating, all the data is lost. It would create slightly more overhead, but maybe if compressing, we should write to disk in a temporary location and allocate a few additional threads for reading data back in and compressing it in the correct location only after a raw chunk has been successfully written.

@aliddell aliddell added the enhancement New feature or request label Jan 27, 2023
@nclack
Copy link
Member

nclack commented Feb 1, 2023

This is interesting.

There are different kinds of failures. We can't do much about something like a sudden loss of power. We can try to minimize latency to disk (reducing risk) but can't make stronger guarantees.

But, I do want to try to provide guarantees about shutdown behavior when handling e.g. an exception. We could think about what should happen when we have a partially buffered chunk and the runtime goes into shutdown. Can we flush it in a meaningful way?

@aliddell aliddell transferred this issue from another repository Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants