Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Logic in Drag Event #68

Open
SvenPam opened this issue Mar 16, 2015 · 0 comments
Open

Wrong Logic in Drag Event #68

SvenPam opened this issue Mar 16, 2015 · 0 comments

Comments

@SvenPam
Copy link

SvenPam commented Mar 16, 2015

Great plugin, just a little bug we found.

In the drag: function, your update function is called all the time which triggers the cropbox event. On line 225 in cropbox.js, the logic is:
if (skipupdate)
To me, it looks like it needs to be
if (!skipupdate)
Semantically this is correct, as update will not be called, it also makes call-backs a heck of a lot smoother!

Hope that helps,

Ste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant