Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: rules_cc is using a yanked version (0.1.0) #1810

Open
Mizux opened this issue Jan 21, 2025 · 2 comments
Open

[Bug]: rules_cc is using a yanked version (0.1.0) #1810

Mizux opened this issue Jan 21, 2025 · 2 comments

Comments

@Mizux
Copy link
Contributor

Mizux commented Jan 21, 2025

Describe the issue

All in the title a rules_cc yanked version is used leading to warning or error to downstream project...

also rules_cc is not in sync contrary to the comment...

abseil-cpp/WORKSPACE

Lines 60 to 66 in a28c4b5

# C++ rules for Bazel
http_archive(
name = "rules_cc",
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.1.0/rules_cc-0.1.0.tar.gz"],
sha256 = "4b12149a041ddfb8306a8fd0e904e39d673552ce82e4296e96fac9cbf0780e59",
strip_prefix = "rules_cc-0.1.0",
)

vs

abseil-cpp/MODULE.bazel

Lines 29 to 31 in a28c4b5

# Please keep the versions in sync with the versions in the WORKSPACE file.
bazel_dep(name = "rules_cc", version = "0.0.17")

broken blame commit:
4024484

Steps to reproduce the problem

read the code

What version of Abseil are you using?

HEAD

What operating system and version are you using?

archlinux

What compiler and version are you using?

gcc --version
gcc (GCC) 14.2.1 20240910
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

What build system are you using?

bazel --version
bazel 8.0.1

Additional context

code review...

@Mizux
Copy link
Contributor Author

Mizux commented Jan 21, 2025

EDIT: Seems bazel play with yanked bit so now 0.1.0 can be used (again?)...
bazelbuild/bazel-central-registry@97f05fe

Still the discrepancy between --enablebzlmod and --enableworkspace exist...

@derekmauro
Copy link
Member

Yes, the different versions are because of the havoc the yanking caused. 0.0.17 didn't work with Bazel 7, so I had to keep it on 0.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants