Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCIO-next: The vulnerability details view UI is too slow to render #1714

Closed
tdruez opened this issue Jan 3, 2025 · 4 comments · Fixed by #1728
Closed

VCIO-next: The vulnerability details view UI is too slow to render #1714

tdruez opened this issue Jan 3, 2025 · 4 comments · Fixed by #1728
Assignees
Labels

Comments

@tdruez
Copy link
Contributor

tdruez commented Jan 3, 2025

From aboutcode-org/dejacode#220 (comment)

@DennisClark I noticed that when I click on a Vulnerability VCID it takes at least 20 seconds to open that vulnerability in public2. I opened public and pasted a VCID there and it also seems really sluggish. I suppose it might have something to do with the high number of affected packages. Do you know if there are performance improvements that still need to be deployed on our public and public2 servers? I am concerned that the really slow response could be rather annoying to a DejaCode user, even though it is a VCIO problem. (Maybe a message such as "Getting affected packages list ..." would take care of it.) Please suggest what we ought to do, if anything, about this, thanks.

A URL such as https://public.vulnerablecode.io/vulnerabilities/VCID-hh72-ne73-aaak can take up to 60 seconds (and sometime timeout) making the app unusable.

@tdruez tdruez added the bug label Jan 3, 2025
@TG1999 TG1999 changed the title The vulnerability details view UI is too slow to render VCIO-NEXT: The vulnerability details view UI is too slow to render Jan 6, 2025
@TG1999 TG1999 changed the title VCIO-NEXT: The vulnerability details view UI is too slow to render VCIO-next: The vulnerability details view UI is too slow to render Jan 6, 2025
@pombredanne
Copy link
Member

pombredanne commented Jan 7, 2025

Here is what I suggest:

  1. We need to tune Postgres conf. Right now the public DB servers uses less than 2GB out of 64GB

  2. The UI should be simplified after some profiling. In particular we should:
    2.1. Remove all package details and open packages in a new page, only on request
    2.2. Move Severities to a new tab
    2.3. Keep weaknesses in a Essentials tab
    2.4. Remove Severities score ranges

Screenshot from 2025-01-07 17-55-57
Screenshot from 2025-01-07 17-56-16

@pombredanne
Copy link
Member

pombredanne commented Jan 23, 2025

@TG1999 what's left to do to close this?
@tdruez have you tried the latest?

@tdruez
Copy link
Contributor Author

tdruez commented Jan 23, 2025

@tdruez have you tried the latest?

Yes, it's now about 600ms to load the page, about 100x faster.
The app is now usable.

@TG1999 Great work on the performances improvements 🚀

@TG1999
Copy link
Contributor

TG1999 commented Jan 23, 2025

This is now completed, as reported by @tdruez views are now 100x faster. https://public.vulnerablecode.io/vulnerabilities/VCID-hh72-ne73-aaak to test this you can open this view and check the speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants