Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the tests to use the latest version of the upgradeable deposit contract #20

Closed
DrZoltanFazekas opened this issue Dec 4, 2024 · 0 comments · Fixed by #21
Closed

Adjust the tests to use the latest version of the upgradeable deposit contract #20

DrZoltanFazekas opened this issue Dec 4, 2024 · 0 comments · Fixed by #21

Comments

@DrZoltanFazekas
Copy link
Contributor

DrZoltanFazekas commented Dec 4, 2024 •
edited
Loading

Currently, the tests are referring to deposit.sol, but they should start using the latest version of the upgradeable deposit contract . No need to deploy an upgradeable proxy, just deploy deposit_v2.sol and populate its storage with the values that are set in the initializer.
@DrZoltanFazekas DrZoltanFazekas changed the title Import the latest version of the upgradeable deposit contract Adjust the tests to use the latest version of the upgradeable deposit contract Dec 4, 2024
@DrZoltanFazekas DrZoltanFazekas linked a pull request Dec 4, 2024 that will close this issue
Improve tests and and compatibility with deposit contract changes #21
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve tests and and compatibility with deposit contract changes Zilliqa/delegated_staking
1 participant
@DrZoltanFazekas