From f86ecce852ae145c7b53cf88d65dd4d0c8fc76e5 Mon Sep 17 00:00:00 2001 From: DrZoltanFazekas Date: Wed, 18 Dec 2024 16:51:45 +0100 Subject: [PATCH] Minor fixes requested by the reviewer --- README.md | 2 +- src/BaseDelegation.sol | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index c31057d..d96fd3e 100644 --- a/README.md +++ b/README.md @@ -118,7 +118,7 @@ cast send --legacy --value 10000000ether --rpc-url http://localhost:4201 --priva ``` with the BLS public key, the peer id and the BLS signature of your node. Note that the peer id must be converted from base58 to hexadecimal format and you must provide the delegation contract address when generating the BLS signature: ```bash -echo '{"secret_key":"...", "chain_id":..., "address":"0x7a0b7e6d24ede78260c9ddbd98e828b0e11a8ea2"}' | cargo run --bin convert-key +echo '{"secret_key":"...", "chain_id":..., "control_address":"0x7a0b7e6d24ede78260c9ddbd98e828b0e11a8ea2"}' | cargo run --bin convert-key ``` Make sure your node is fully synced before you run the above command. diff --git a/src/BaseDelegation.sol b/src/BaseDelegation.sol index 3ab1251..4c8f42a 100644 --- a/src/BaseDelegation.sol +++ b/src/BaseDelegation.sol @@ -192,7 +192,8 @@ abstract contract BaseDelegation is IDelegation, PausableUpgradeable, Ownable2St uint256 firstPending = index; claims = new uint256[2][](fifo.last - index); while (fifo.notReady(index)) { - claims[index - firstPending] = [fifo.items[index].blockNumber, fifo.items[index].amount]; + WithdrawalQueue.Item storage item = fifo.items[index]; + claims[index - firstPending] = [item.blockNumber, item.amount]; index++; } }