Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxxrtl: fix formatting of UNICHAR #4646

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

rroohhh
Copy link
Contributor

@rroohhh rroohhh commented Oct 9, 2024

This caused compilation to fail when the argument of any, not just UNICHAR formatting operations, is bigger than 32 bits.

Fixes #4644

This caused compilation to fail when the argument of any, not just
UNICHAR formatting operations, is bigger than 32 bits.

Fixes YosysHQ#4644
@rroohhh rroohhh requested a review from whitequark as a code owner October 9, 2024 12:09
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitequark whitequark merged commit a761999 into YosysHQ:main Oct 9, 2024
25 of 26 checks passed
@rroohhh rroohhh deleted the cxxrtl_fmt_unichar branch October 10, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code generated by write_cxxrtl fails to compile with big arguments to $write
2 participants