Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix l10n import/export tool buttons actions #21763

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

edpittol
Copy link
Contributor

@edpittol edpittol commented Oct 28, 2024

Context

No action is taken on Import from other SEO plugins tool when using translated plugin.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes Import from other SEO plugins tool actions when the buttons are translated to the installation language. Props to edpittol.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install RankMath or other SEO plugin and change some settings.
  • Change site language to a different language other than English ( or change language in user profile ).
  • Deactivate that SEO plugin and install Yoast SEO
  • Go to Yoast SEO and go to Yoast SEO->Tools->Import/export
  • Select to import data from another SEO plugin, select the SEO plugin you deactivate.
  • Click on "Import" (in a different language)
  • Check you get success message that the data was imported.
  • Repeat those step only instead of importing, do the cleanup of that data.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #21762

@vraja-pro vraja-pro self-assigned this Nov 26, 2024
@vraja-pro vraja-pro added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label Nov 26, 2024
@vraja-pro vraja-pro changed the base branch from trunk to feature/plugin-fixes November 26, 2024 12:48
@vraja-pro vraja-pro added this to the feature/plugin-fixes milestone Nov 26, 2024
@vraja-pro
Copy link
Contributor

CR & AC ✅

@vraja-pro vraja-pro merged commit 660fb90 into Yoast:feature/plugin-fixes Nov 26, 2024
19 of 20 checks passed
@edpittol edpittol deleted the patch-1 branch November 26, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog community-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import tool actions do not work with translated button label
4 participants