Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF Compare Script: Refactor logic to pull in current Runtime Version #230

Closed
sihammill opened this issue Feb 26, 2025 · 0 comments · Fixed by #234
Closed

TF Compare Script: Refactor logic to pull in current Runtime Version #230

sihammill opened this issue Feb 26, 2025 · 0 comments · Fixed by #234
Assignees
Labels
refactor An improvement to existing test/module code

Comments

@sihammill
Copy link
Contributor

sihammill commented Feb 26, 2025

Description

Issue

Currently the runtime version isn't passed through the jobs in the pipeline and this is something we need as the RT version is added to the bug reports when they are created and when the comments are automatically updated.
This basic bit of information is vital for the devs to see what RT is affected.

Current workaround

As it stands, the only real way to get the RT version is to download the logs for the current workflow run which includes the version, we then extract the version and save it to a variable. It's not pretty but it works (well not now).

Proposal

Look through the pipeline code and see if there is a way we can get the current RT version more reliably, maybe get it form the config file that is passed in to the pipeline, also maybe use the logs as a fall back. way of extracting the RT version.

Update

a GitHub variable has been setup for the Runtime Version: ${{ github.event.inputs.RUNTIME_VERSION }}

Adding this as a parameter to the command line in the workflow files that calls the tf_compare.py file would mean the parameter can then be accessed within the python file using:

parser = argparse.ArgumentParser(description="GitHub Artifact Processor")
parser.add_argument('--rt', type=str, required=True, help="Current Runtime Version")
args = parser.parse_args()
RTVersion = args.rt

The updated command line for the workflow file would be:

python .\tf_compare.py --github-token ${{ [secrets.GH](http://secrets.gh/)_PERSONAL_ACCESS_TOKEN }} --workflow ${{ github.workflow }}.yml --rt ${{ github.event.inputs.RUNTIME_VERSION }}

Script Name

tf_compare.py

@sihammill sihammill added the refactor An improvement to existing test/module code label Feb 26, 2025
@sihammill sihammill self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor An improvement to existing test/module code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant