Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit on a different list gives mismatch error message #5

Open
YiFei2 opened this issue Apr 16, 2022 · 1 comment
Open

Edit on a different list gives mismatch error message #5

YiFei2 opened this issue Apr 16, 2022 · 1 comment

Comments

@YiFei2
Copy link
Owner

YiFei2 commented Apr 16, 2022

image.png

Error message indicates an invalid index provided, however, the error is that I am editing on an invalid list for the editp command. Hence, the error message does not match the error in behaviour.

@nus-se-script
Copy link

nus-se-script commented Apr 19, 2022

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unintuitive error message when editing the wrong list

Problem:

When trying to edit details on the wrong list (e.g. editp when the list is showing companies) give an unintuitive error message as shown.

Screenshot 2022-04-16 at 3.02.36 PM.png

Why is it an issue:

Since editing a person's company name requires a match with the name of previously added companies, it is possible that such a scenario happens:

  1. User tries to update the company name of a added person
  2. User entered the wrong name as the company name is not straightforward (e.g. *DBSSSS vs DBSSS)
  3. User uses listc to verify the exact name
  4. User tries to use editp while the company list is showing

This seems to be a valid scenario, but the error message will not help guide the users to the correct list to execute the command.


[original: nus-cs2103-AY2122S2/pe-interim#1346] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Reason for changing to Low

image.png

The UG has specified that the commands will not work if the displayed list is incorrect. In particular, this is accounting the feature freeze given (unable to change the error message), but we have put appropriate information in the UG.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants