Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate addcommand diagram #13

Open
YiFei2 opened this issue Apr 16, 2022 · 1 comment
Open

Inaccurate addcommand diagram #13

YiFei2 opened this issue Apr 16, 2022 · 1 comment

Comments

@YiFei2
Copy link
Owner

YiFei2 commented Apr 16, 2022

image.png

XYZ is supposed to be a placeholder for either a company, person, or event. However, for the adding of a person or event, the checking of the company being in the company list is not shown in the Activity Diagram. The diagram only shows the checking for valid parameters and duplicate objects.

image.png

In the following description, only the checking of duplicate objects is written.

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 19, 2022

Team's Response

Not an issue.

Notice that addXYZ is indeed a placeholder for addCompany, addEvent, and addPerson. Therefore, it is intended to only put the common workflow between them. The details of the difference between each addCompany, addEvent, and addPerson is explained in the sequence diagram below it. To dive deeper into each of the addXYZ command details, there are already specific sections for them.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants