Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify vendors about conflicting modules #748

Open
bskqd opened this issue Mar 16, 2023 · 0 comments · May be fixed by #782
Open

Notify vendors about conflicting modules #748

bskqd opened this issue Mar 16, 2023 · 0 comments · May be fixed by #782
Assignees

Comments

@bskqd
Copy link
Contributor

bskqd commented Mar 16, 2023

While parsing the files we can encounter files that are already available in the save-file-dir (which means that they have already been parsed before) and the hash of the two modules at this point is different, so we have to understand if these modules have only formatting changes (different quotes around strings, whitespace changes, additional comments, etc.), or the content of these files is different and if the content is different then we have to notify the vendors that this is a bad practice, and they should create another revision for such changes.

@bskqd bskqd self-assigned this Mar 16, 2023
@bskqd bskqd changed the title Notify vendors about semantically incorrect modules Notify vendors about conflicting modules Mar 22, 2023
@bskqd bskqd linked a pull request Jun 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant