Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significance of rgb_mean #2

Open
terrainer opened this issue Jan 26, 2024 · 1 comment
Open

Significance of rgb_mean #2

terrainer opened this issue Jan 26, 2024 · 1 comment

Comments

@terrainer
Copy link

Hi,

Thank you for your code! I have been very interested in one aspect in particular. Many papers' code implementations (including SwinIR, HAT, DAT, and more recently, SPAN) make use of the rgb_mean code that is commented out here.
I have noticed that doing the same with the SPAN code implementation code greatly increases training stability, but breaks compatibility due to its interaction with the network features.

I was wondering if you could explain why you've chosen not to include it in your implementation, and what pros and cons you know of when using it?

Kind regards,
terrainer

@terrainer terrainer changed the title Signifigance of rgb_mean Significance of rgb_mean Jan 26, 2024
@XY-boy
Copy link
Owner

XY-boy commented Jan 26, 2024

Hi,

Thank you for your code! I have been very interested in one aspect in particular. Many papers' code implementations (including SwinIR, HAT, DAT, and more recently, SPAN) make use of the rgb_mean code that is commented out here. I have noticed that doing the same with the SPAN code implementation code greatly increases training stability, but breaks compatibility due to its interaction with the network features.

I was wondering if you could explain why you've chosen not to include it in your implementation, and what pros and cons you know of when using it?

Kind regards, terrainer

Hi. As far as I know, this operation is used to boost the performance on specific training dataset, such as DIV2K. As I train TTST on remote sensing datasets, therefore I comment this operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants