Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]The “View Source” button in the X# Runtime documentation is not working and more #1651

Closed
vfp9 opened this issue Dec 7, 2024 · 1 comment
Assignees
Milestone

Comments

@vfp9
Copy link
Contributor

vfp9 commented Dec 7, 2024

The browser cannot open the correct page after clicking the button.

For example, for the “DbUseAreaFox” function, after clicking on it, the URL is:
https://github.com/X-Sharp/XSharpPublic/blob/feature/Runtime/src/Runtime/ XSharp.VFP/Database/DbFunctions.prg
The correct site should be:
https://github.com/X-Sharp/XSharpPublic/blob/main/src/Runtime/XSharp.VFP/Database/DbFunctions.prg

The issue seems to be related to the setting of Transform Args-baseSourceCodeUrl in the SHFB project.

Also, the link pointed to by “The source code for the XSharp Runtime is available on GitHub.
” in the Summary of the SHFB project is incorrect.

Third, the font is too small in the X# Runtime documentation.

@vfp9 vfp9 changed the title [DOC]The “View Source” button in the X# Runtime documentation is not working. [DOC]The “View Source” button in the X# Runtime documentation is not working and more Dec 7, 2024
@RobertvanderHulst
Copy link
Member

This is caused by the fact that we have deleted the feature/Runtime branch.
I will add this branch back for now, and will adjust the link in the next build of the product.

@github-project-automation github-project-automation bot moved this to To do in Build 2.2 Dec 9, 2024
@RobertvanderHulst RobertvanderHulst self-assigned this Dec 9, 2024
@RobertvanderHulst RobertvanderHulst moved this from To do to In progress in Build 2.2 Dec 9, 2024
@RobertvanderHulst RobertvanderHulst moved this from In progress to Needs testing in Build 2.2 Dec 24, 2024
@RobertvanderHulst RobertvanderHulst added this to the 2.2 milestone Dec 24, 2024
@RobertvanderHulst RobertvanderHulst moved this from Needs testing to Done in Build 2.2 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants