Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Void method returning boolean #73

Open
gplanchat opened this issue Dec 10, 2021 · 1 comment
Open

Void method returning boolean #73

gplanchat opened this issue Dec 10, 2021 · 1 comment

Comments

@gplanchat
Copy link

Hello,

In the class WyriHaximus\React\ChildProcess\Pool\ProcessCollection\Single, the next method is returning a bool value (which isalways false). this next method should have a void return type, following the Iterator interface.

I cannot find any usage of this value elsewhere than in tests. Is this return value necessary in some point ?
@WyriHaximus
Copy link
Owner

IIRC it shouldn't so feel free to PR it out of there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WyriHaximus @gplanchat