Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MobOwner Cheat #608

Open
RealmKebab opened this issue Mar 23, 2022 · 16 comments
Open

MobOwner Cheat #608

RealmKebab opened this issue Mar 23, 2022 · 16 comments
Labels
category:render help wanted Extra attention is needed status:never-stale Prevents StaleBot from marking this item as stale. type:enhancement New feature or request type:new feature A new hack/command/etc.

Comments

@RealmKebab
Copy link

RealmKebab commented Mar 23, 2022

Before posting, please make sure that this hasn't already been suggested by someone else.

Description

This cheat is pretty useful for 1.18 or below versions anarchy servers and some random "SMP" servers.
And this cheat appears in alot of clients, so I want it added to this one.

What it does is: If you don't have OP on the server, you can't see mob owner's without the /data get entity command.

Instead of that, The module will display a overhead nametag with the owner of mob's name displaying

Example: Wolf, Tamed by Notch
Name above it: Owned By Notch
insert wolf here
Any mob that is tameable and is tamed will be displayed with the owner of the mobs name.
Speific Colors for the name:

Red if the player is not on the server

Green is the player IS on the server.

Screenshots / Videos (Optional)

I have no idea how to send a large file so I'm not using screenshots or videos.
Or just use another client and see how it looks like.

@RealmKebab RealmKebab added the type:enhancement New feature or request label Mar 23, 2022
@sudofox
Copy link
Contributor

sudofox commented Apr 6, 2022

Just a heads up that the owner is stored in the entity data as a UUID which requires making an API call to Mojang to resolve it to a username. As an end user, you might want to look at WTHIT or other mods that provide additional info (there is a PetOwner one).

If this does get added, care should be taken to handle situations in which we're unable to reach the Mojang API e.g playing when not connected to the internet and taming an animal, or looking at a world download

@ThisTestUser
Copy link
Contributor

Here's my implementation of your idea: ThisTestUser@fb3e433

If the API cannot be reached, it just displays the UUID. This can also happen if the server is in offline mode, which is why the mod will also try to resolve the player name from the tab list.

@RealmKebab
Copy link
Author

Here's my implementation of your idea: ThisTestUser@fb3e433

If the API cannot be reached, it just displays the UUID. This can also happen if the server is in offline mode, which is why the mod will also try to resolve the player name from the tab list.

How long would this take or has it been completed?

@ThisTestUser
Copy link
Contributor

You can download the 1.19.2 version of Wurst with this feature from my repo: https://github.com/ThisTestUser/Wurst7/releases

@RealmKebab
Copy link
Author

RealmKebab commented Jun 29, 2023

Just a heads up that the owner is stored in the entity data as a UUID which requires making an API call to Mojang to resolve it to a username. As an end user, you might want to look at WTHIT or other mods that provide additional info (there is a PetOwner one).

WTHIT requires itself to be on server to see who is the owner of the pet, Simple reason why it won't wont work (for wthit)
If you own that pet, wthit WILL be able to tell you own it. But any pet owned by others? No, It won't be able to tell you.

@RealmKebab
Copy link
Author

I have no absolute idea if this feature is being worked on or not, but i'll wait since patience is an important key.

@Alexander01998
Copy link
Member

I appreciate your patience but I want to set expectations correctly. I'm not currently working on a MobOwner feature. Right now, my primary focus is on setting up a forum for the Wurst community, as our subreddit has suddenly become unusable with the recent Reddit API changes. This is a bit of an emergency, so I've had to put everything else on hold for now.

Once the forum is successfully up and running, my aim will be to work on and implement some of the most popular feature requests that received a lot of upvotes on the recent Wurst 7.36 voting post. Unfortunately, MobOwner didn't receive any votes there, so it probably won't be included in the v7.36 update.

However, maybe it will gain popularity in a future poll? I learnt a lot from the 7.36 post and I definitely plan to keep doing these polls on the forum (once I figure out how to replicate Reddit's contest mode).

@RealmKebab
Copy link
Author

Alright 👍

@ThisTestUser
Copy link
Contributor

I already have a MobOwner feature created (as MobInfo), but I'm waiting for #801 to be merged first.

@Cyclopropinon
Copy link

lets hope it will be soon

This comment was marked as outdated.

@Alexander01998

This comment was marked as outdated.

@RealmKebab
Copy link
Author

This now would be actually more useful for operators and normal players since mojang somehow screwed up the /data get entity <EntityID> Owner
Output of the command:
image

This comment was marked as outdated.

@Alexander01998
Copy link
Member

Still relevant.

The /data get command now returns the UUID as an array of 4 integers, but luckily calling wolf.getOwnerUuid() still returns the UUID in its usual format. This means existing MobOwner implementations should not be affected.

For displaying the owner, we need a system that can display custom nametags similar to the one proposed in #801, but with better support for multiple tags. #801's current system with the manual vOffset parameter is not sophisticated enough to ensure that multiple tags coming from different hacks won't overlap or have gaps between them.

@Alexander01998 Alexander01998 added status:never-stale Prevents StaleBot from marking this item as stale. and removed status:stale labels Apr 2, 2024
@coolnoob78
Copy link

any updates on this?

@Wurst-Imperium Wurst-Imperium deleted a comment from github-actions bot Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:render help wanted Extra attention is needed status:never-stale Prevents StaleBot from marking this item as stale. type:enhancement New feature or request type:new feature A new hack/command/etc.
Projects
No open projects
Development

No branches or pull requests

6 participants