Settings to allow booking rules to send ics attachments #801
+137
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting to toggle sending an ics attachment to booking_rules and a separate toggle to denoted if the attachments should an update or create ics. Actual attachment is handled in the message controller. This should probably be moved to the method somewhere but I wasn't sure where.
|
This is linked to #732 |
|
Hi, thank you for your contribution. we run the tests and have a look at it. If it works, we accept it. All the best! |
|
Hi, sorry, could you rebase your request on the urise branch, where currently all tests are green? As you can see, the automatic tests have failed. It could have been our fault, but we can't accept a request with failing tests. |
|
Hi, @danbuntu |
…der correctly in Googlemail/ calendar, so I've added X-ALT-DESC to the ics. I've also done a quick and dirty to render the urls as links.
georgmaisser
merged commit acd476a
into
Wunderbyte-GmbH:MOODLE_401_TESTING
0 of 28 checks passed
bernhard-wunderbyte
pushed a commit
that referenced
this pull request
Feb 11, 2025
* Settings to allow booking rules to send ics attachments Setting to toggle sending an ics attachment to booking_rules and a separate toggle to denoted if the attachments should an update or create ics. Actual attachment is handled in the message controller. This should probably be moved to the method somewhere but I wasn't sure where. * fix issues raised by CI * We've noticed that ics files with html or new lines in them don't render correctly in Googlemail/ calendar, so I've added X-ALT-DESC to the ics. I've also done a quick and dirty to render the urls as links.
1 task
georgmaisser
pushed a commit
that referenced
this pull request
Feb 12, 2025
* Settings to allow booking rules to send ics attachments Setting to toggle sending an ics attachment to booking_rules and a separate toggle to denoted if the attachments should an update or create ics. Actual attachment is handled in the message controller. This should probably be moved to the method somewhere but I wasn't sure where. * fix issues raised by CI * We've noticed that ics files with html or new lines in them don't render correctly in Googlemail/ calendar, so I've added X-ALT-DESC to the ics. I've also done a quick and dirty to render the urls as links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting to toggle sending an ics attachment to booking_rules and a separate toggle to denoted if the attachments should an update or create ics.
Actual attachment is handled in the message controller. This should probably be moved to the method somewhere but I wasn't sure where.