Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal_cancel_all_addcredit display only fixed values quota consumed and do not show actual quota consumed by user #117

Open
semteacher opened this issue Dec 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@semteacher
Copy link
Collaborator

semteacher commented Dec 28, 2024

During testing on "cancellation all users" (booking/777) I found that in the modal_cancel_all_addcredit modal only ixed values quota consumed gas shown - when actual quota consumed by user not beig show.
Further debugging reveals that only
get_config('local_shopping_cart', 'calculateconsumationfixedpercentage')
has been processed in the definition() method.
And
get_config('local_shopping_cart', 'calculateconsumation')
was not procedded at all.
PS: I have proposed a solution

@semteacher semteacher added the bug Something isn't working label Dec 28, 2024
semteacher added a commit that referenced this issue Dec 28, 2024
…a consumed and do not show actual quota consumed by user" (#117)
semteacher added a commit that referenced this issue Dec 28, 2024
…a consumed and do not show actual quota consumed by user" (#117)
@semteacher semteacher moved this to In Progress in Shopping Cart Jan 5, 2025
semteacher added a commit that referenced this issue Jan 5, 2025
…a consumed and do not show actual quota consumed by user" (#117)
semteacher added a commit that referenced this issue Jan 5, 2025
…a consumed and do not show actual quota consumed by user" (#117)
@semteacher
Copy link
Collaborator Author

I also noticed that setting
image
not being applied in case of "cancell all" action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants