From be5ae55caae1a4b88637dbbb4bc096d770a53d65 Mon Sep 17 00:00:00 2001 From: Daniel Richards Date: Thu, 11 Jul 2024 16:17:48 +0800 Subject: [PATCH 1/3] Reduce specificity of navigation text decoration rule --- packages/block-library/src/navigation/style.scss | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/block-library/src/navigation/style.scss b/packages/block-library/src/navigation/style.scss index 41606d5431e3f..599f44d30f26f 100644 --- a/packages/block-library/src/navigation/style.scss +++ b/packages/block-library/src/navigation/style.scss @@ -76,14 +76,12 @@ $navigation-icon-size: 24px; } } - &:where(:not([class*="has-text-decoration"])) { - a { - text-decoration: none; + &:where(:not([class*="has-text-decoration"])) :where(a) { + text-decoration: none; - &:focus, - &:active { - text-decoration: none; - } + &:focus, + &:active { + text-decoration: none; } } From 0f9669a834c465c983b50376b065f61320e3ad69 Mon Sep 17 00:00:00 2001 From: Daniel Richards Date: Fri, 12 Jul 2024 15:31:29 +0800 Subject: [PATCH 2/3] Apply Aaron suggestion to also lower specificity for focus/active --- packages/block-library/src/navigation/style.scss | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/block-library/src/navigation/style.scss b/packages/block-library/src/navigation/style.scss index 599f44d30f26f..734e3bd04cb76 100644 --- a/packages/block-library/src/navigation/style.scss +++ b/packages/block-library/src/navigation/style.scss @@ -76,11 +76,10 @@ $navigation-icon-size: 24px; } } - &:where(:not([class*="has-text-decoration"])) :where(a) { - text-decoration: none; - - &:focus, - &:active { + &:where(:not([class*="has-text-decoration"])) { + & :where(a), + & :where(a:focus), + & :where(a:active) { text-decoration: none; } } From 56fcc6f97045c28e31778bd1f77b8a49e1e3f58e Mon Sep 17 00:00:00 2001 From: Daniel Richards Date: Tue, 16 Jul 2024 15:34:36 +0800 Subject: [PATCH 3/3] Remove `:not([class*="has-text-decoration"])` from selector --- packages/block-library/src/navigation/style.scss | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/block-library/src/navigation/style.scss b/packages/block-library/src/navigation/style.scss index 734e3bd04cb76..3d7a8810ae9b7 100644 --- a/packages/block-library/src/navigation/style.scss +++ b/packages/block-library/src/navigation/style.scss @@ -76,12 +76,10 @@ $navigation-icon-size: 24px; } } - &:where(:not([class*="has-text-decoration"])) { - & :where(a), - & :where(a:focus), - & :where(a:active) { - text-decoration: none; - } + & :where(a), + & :where(a:focus), + & :where(a:active) { + text-decoration: none; } // Submenu indicator.