Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Rename data-wp-island to data-wp-interactive #238

Closed
luisherranz opened this issue May 25, 2023 · 2 comments · Fixed by #239
Closed

Rename data-wp-island to data-wp-interactive #238

luisherranz opened this issue May 25, 2023 · 2 comments · Fixed by #239

Comments

@luisherranz
Copy link
Member

We inherited the name from the JavaScript ecosystem, but it's true that there's no context in WordPress to understand what is an island. So maybe we should rename it to data-wp-interactive. What do you think?

Changed suggested by @carolinan here.
@luisherranz luisherranz mentioned this issue May 25, 2023
Merged
@SantosGuillamot
Copy link
Contributor

It makes sense to me 🙂 I can imagine many users getting confused about what an island is, and they don't really need to know unless they are really interested. data-wp-interactive seems clearer in that regard.

@luisherranz
Copy link
Member Author

Ok, let's make this change then 🙂

@luisherranz luisherranz mentioned this issue May 31, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename sufix character and island directive WordPress/block-interactivity-experiments
2 participants
@luisherranz @SantosGuillamot