Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Heuristic for Commons (common goods) #167

Open
HerziPinki opened this issue Jul 17, 2023 · 2 comments
Open

improve Heuristic for Commons (common goods) #167

HerziPinki opened this issue Jul 17, 2023 · 2 comments
Assignees

Comments

@HerziPinki
Copy link
Collaborator

Original complaint: https://commons.wikimedia.org/wiki/User_talk:Herzi_Pinki#WikiDaheim_-_Schwarzach_(Vorarlberg)
The incriminated behavior is that a pipe organ from another municipality (not even nearby) is selected as image for the local cemetery.

I have created a cemetery category for Schwarzach, now the Cemetery is shown as common good, but the pipe organ from Dalaas is also and still listed as missing cemetery category.

The original problem was caused by [[:File:Dalaas Orgel.jpg]] is in [[:Category:Anton Behmann]] -> [[:Category:Schwarzach (Vorarlberg)]] the municipality and via [[:Category:Pfarrkirche hl. Oswald und Friedhof, Dalaas]] -> [[:Category:Cemeteries in Vorarlberg]] also a cemetery. (my analysis)
I feel that the secondary problem (still listed after creating a real cemetery) is also related to the above relationship.

I have an idea to generally solve this: the problem is that people (like organ builders and architects) are assigned to the category of their municipality (if they lived there), and that their works (around the globe) are assigned to them. So in generally the chain municipality -> person -> work does not lead to works related to the municipality (If so, these works should be assigned to the municipality with a separate chain anyway.) We can break the chain by ignoring any category being in [[Category:People by name]] and cutting the category search there.

Wonder if this is a feasible approach? Seems to me a backend issue.

@pixelhaufen
Copy link

'People of*' - which works for bigger municipalities - is already excluded. For this specific case I also added 'Anton Behmann'. Comparing against 865343 categories - no idea how well the commons api takes big a query like this - (+ the existing exemptions) would require some additional work / rewriting the exclusion, adding a table for the exceptions, reading the data and organizing the update. I would prefer not to make a big change like this during the running contest.

@HerziPinki
Copy link
Collaborator Author

adding Anton Behmann did not have the desired effect (within 6 hours). I now put the two persons to [[Category:People of Schwarzach (Vorarlberg)]]. Which finally removed the pipe organ.
Now there a three objects in the list (filtering by name makes it much more obvious), all with the same image:

  • the monument 'Friedhof christlich'
  • the Category:Friedhof Schwarzach (Vorarlberg) as common goods (source wikidata linking to Category:Friedhof Schwarzach (Vorarlberg) (!))
  • a cemetery as common goods, source Category:Schwarzach (Vorarlberg), saying Es gibt auf Commons noch keine Kategorie vom Friedhof in dieser Gemeinde.

So at least the last is wrong (there is a cemetery category and thus a cemetery), could this be filtered away? (I do not remember: do we ask for common goods even if they are already there, because there could be another cemetery, school, etc., or do we stop asking for more, if there is already one of those?).

could the first 2 be collapsed to a single one, as both have the same commons category (so matching them should be possible)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants