Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsolved references in train.py and test_online.py #19

Open
dahyun-kang opened this issue Jan 8, 2021 · 2 comments
Open

Unsolved references in train.py and test_online.py #19

dahyun-kang opened this issue Jan 8, 2021 · 2 comments

Comments

@dahyun-kang
Copy link

dahyun-kang commented Jan 8, 2021

Dear authors.

Hello,
I found that train.py shows many unsolved references. For example,
optimizer = optim.SGD([{'params': get_10x_lr_params(model), 'lr': args.lr}], lr=args.lr, momentum=args.momentum, weight_decay=args.weight_decay)
and
from Network import network.
References for get_10x_lr_params and Network are missing.

test_online.py, which you refered to test.py at README, is not working either. It uses dataset_val, while you have applied multi-scale testing of dataset_test according to this issue.

I assume these are typos from refactoring.
Could you please double-check if your code runs?

Thank you.

@dahyun-kang dahyun-kang changed the title Unsolved references in train.py Unsolved references in train.py and test_online.py Jan 8, 2021
@Wi-sc
Copy link
Owner

Wi-sc commented Jan 14, 2021

Sorry for that. The function get_10x_lr_params should be get_lr_params and Network should be Brinet. I have corrected them.

@lewnus
Copy link

lewnus commented Mar 8, 2021

Sorry for that. The function get_10x_lr_params should be get_lr_params and Network should be Brinet. I have corrected them.

The test_online.py has not yet been corrected.

I try to correct it by myself and the MIoU of the model you provided can only reach 64.6 in pascal voc fold1, which is 67.20 in the paper. Could you please provide a correct test script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants