Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOTTERY] As long as no participants are delinquent, remove startRound time constraint #166

Open
blorange opened this issue Jun 5, 2017 · 2 comments

Comments

@blorange
Copy link

blorange commented Jun 5, 2017

This was just a general thought, but it would remove any concerns about wasting gas, and means there would be less 'checking in' to see when it was possible to start the next round. It wouldn't be very fair in a bidding Circle, but in a lottery or a predefined one I think this feature would be useful.

WDYT @shine2lay @rmerom?

@rmerom
Copy link
Contributor

rmerom commented Jun 5, 2017

I think we can work more on the whole round thing. What do you think is the idea round-advancement mechanism? I'd think it should be "automatic", so that ROSCAs are deterministic and it's easy for each participant to understand when a round starts and when it ends. What do you think?

@blorange
Copy link
Author

blorange commented Jun 5, 2017

Yeah I agree - I do think automatic is better. The only concern is the massively variable gas costs if we want to bake startRound into the existing functions.

What about having the round-processing functions moved over to the 'withdraw' function? So the amounts for the user are only calculated on withdrawal? It might not save on gas, but it would mean that we're trying to have constant gas costs for each function, which IMO is somewhat important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants