From b37c81c9853340af8a4dba9900f42a6f9e4a5b1b Mon Sep 17 00:00:00 2001 From: Gancho Radkov Date: Wed, 29 May 2024 16:53:54 +0300 Subject: [PATCH 1/2] fix: url validation message --- packages/sign-client/src/client.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sign-client/src/client.ts b/packages/sign-client/src/client.ts index 4d5985d5f..303b7d098 100644 --- a/packages/sign-client/src/client.ts +++ b/packages/sign-client/src/client.ts @@ -71,7 +71,7 @@ export class SignClient extends ISignClient { throw new Error("description is required value in metadata"); } if (!metadata.url) { - throw new Error("description is required value in metadata"); + throw new Error("url is required value in metadata"); } } From c21a7d5ac12dc4e278ca2ae78f6c5da919bd44fb Mon Sep 17 00:00:00 2001 From: Gancho Radkov Date: Wed, 29 May 2024 16:57:02 +0300 Subject: [PATCH 2/2] feat: adds test --- packages/sign-client/test/sdk/client.spec.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/sign-client/test/sdk/client.spec.ts b/packages/sign-client/test/sdk/client.spec.ts index 903ed0157..2da25f0d1 100644 --- a/packages/sign-client/test/sdk/client.spec.ts +++ b/packages/sign-client/test/sdk/client.spec.ts @@ -66,6 +66,19 @@ describe("Sign Client Integration", () => { }), ).rejects.toThrowError("description is required value in metadata"); }); + it("should not initialize with invalid metadata url", async () => { + await expect( + SignClient.init({ + ...TEST_SIGN_CLIENT_OPTIONS, + metadata: { + ...TEST_INVALID_METADATA, + description: "description", + }, + name: "init", + signConfig: { disableRequestQueue: true }, + }), + ).rejects.toThrowError("url is required value in metadata"); + }); describe("connect", () => { it("connect (with new pairing)", async () => {