diff --git a/packages/core/src/controllers/pairing.ts b/packages/core/src/controllers/pairing.ts index 2fd1ae77c..f844156c4 100644 --- a/packages/core/src/controllers/pairing.ts +++ b/packages/core/src/controllers/pairing.ts @@ -35,7 +35,7 @@ import { isJsonRpcResult, isJsonRpcError, } from "@walletconnect/jsonrpc-utils"; -import { FIVE_MINUTES, ONE_MINUTE, toMiliseconds } from "@walletconnect/time"; +import { FIVE_MINUTES, toMiliseconds } from "@walletconnect/time"; import EventEmitter from "events"; import { PAIRING_CONTEXT, @@ -187,7 +187,7 @@ export class Pairing implements IPairing { public activate: IPairing["activate"] = async ({ topic }) => { this.isInitialized(); - const expiry = calcExpiry(ONE_MINUTE); + const expiry = calcExpiry(FIVE_MINUTES); this.core.expirer.set(topic, expiry); await this.pairings.update(topic, { active: true, expiry }); }; @@ -195,6 +195,7 @@ export class Pairing implements IPairing { public ping: IPairing["ping"] = async (params) => { this.isInitialized(); await this.isValidPing(params); + this.logger.warn("ping() is deprecated and will be removed in the next major release."); const { topic } = params; if (this.pairings.keys.includes(topic)) { const id = await this.sendRequest(topic, "wc_pairingPing", {}); diff --git a/packages/core/test/pairing.spec.ts b/packages/core/test/pairing.spec.ts index b2279e306..265ebb494 100644 --- a/packages/core/test/pairing.spec.ts +++ b/packages/core/test/pairing.spec.ts @@ -3,7 +3,7 @@ import { ICore } from "@walletconnect/types"; import { Core, CORE_PROTOCOL, CORE_VERSION, PAIRING_EVENTS, SUBSCRIBER_EVENTS } from "../src"; import { TEST_CORE_OPTIONS, disconnectSocket, waitForEvent } from "./shared"; import { calcExpiry, generateRandomBytes32, parseUri, toBase64 } from "@walletconnect/utils"; -import { FIVE_MINUTES, ONE_MINUTE } from "@walletconnect/time"; +import { FIVE_MINUTES } from "@walletconnect/time"; const createCoreClients: () => Promise<{ coreA: ICore; coreB: ICore }> = async () => { const coreA = new Core(TEST_CORE_OPTIONS); @@ -124,11 +124,10 @@ describe("Pairing", () => { await coreA.pairing.activate({ topic }); const activePairing = coreA.pairing.pairings.get(topic); expect(activePairing.active).toBe(true); - expect(activePairing.expiry > inactivePairing.expiry).toBe(false); // inactive pairing should have an expiry of 5 minutes expect(inactivePairing.expiry).to.be.approximately(calcExpiry(FIVE_MINUTES), 5); - // active pairing should have an expiry of 1 minute - expect(activePairing.expiry).to.be.approximately(calcExpiry(ONE_MINUTE), 5); + // active pairing should still have an expiry of 5 minutes + expect(activePairing.expiry).to.be.approximately(calcExpiry(FIVE_MINUTES), 5); }); });