Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Improve logging #62

Open
joshschmelzle opened this issue Nov 4, 2024 · 3 comments
Open

[FEAT] Improve logging #62

joshschmelzle opened this issue Nov 4, 2024 · 3 comments

Comments

@joshschmelzle
Copy link
Member

Issue to improve logging throughout core. Related PR is #26.

Proposing to consider Pr #26 switching to structlog.

Consider 3 levels per Ben's comment here #26 (comment).

A nice to have would be a way to bring logs into grafana.

@joshschmelzle joshschmelzle changed the title [FEAT] Logging [FEAT] Improve logging Nov 4, 2024
@joshschmelzle
Copy link
Member Author

#26 has been merged which has quite a few changes for logging.

@joshschmelzle
Copy link
Member Author

/var/log/wlanpi_core/debug/debug.log is in JSON format which should be easy to ingest into grafana.

@bentumbler what do you think about changing the log format for /var/log/wlanpi_core/app.log to match? right now they're different.

@bentumbler
Copy link
Contributor

A good idea for the backlog but as we are unlikely to implement anything to consume the logs anytime soon shall we just freeze where we are now for continued testing and pick this back up after WLPC.
Significant testing of the api starts on Saturday so if you do want to do something sooner then maybe target cop Friday for feature freeze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants