Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of FrozenArray<SharedStorageUrlWithMetadata> as an argument type makes no sense #143

Closed
domenic opened this issue Apr 3, 2024 · 2 comments

Comments

@domenic
Copy link

domenic commented Apr 3, 2024

The spec has two methods which take FrozenArray<SharedStorageUrlWithMetadata>.

It's not clear what was intended here. But per the Web IDL spec, almost the exact same set of values are accepted compared to accepting the more conventional sequence<SharedStorageUrlWithMetadata>.

(The difference is that certain proxies for arrays, which define throwing getOwnPropertyDescriptor() traps, would be rejected, because in theory the implementation is supposed to freeze the incoming array.)

We'd like to prohibit the usage of FrozenArray<T> as a parameter type in Web IDL, per whatwg/webidl#1399. It would be lovely if you could move to using sequence<>s.

@domenic
Copy link
Author

domenic commented Jun 21, 2024

Ping! This is one of the last things we need to fix to help with whatwg/webidl#1399.

xyaoinum added a commit that referenced this issue Jun 21, 2024
This addresses issue #143. i.e. `FrozenArray<T>` should be prohibited as a parameter type in Web IDL.
@xyaoinum
Copy link
Collaborator

This is done in: #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants