You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Unit test may let pass the case where we forget to correctly export files in the NPM package.
We absolutely need to run yarn run build locally before publishing packages, so we need a way to secure this process.
Describe the solution you'd like
We could have multiple strategies, like running npm pack --dry-run.
We can also add a publish + prepublish script that forces the build, but that can be annoying when you have already built the app and want to skip this step. I'd rather check if the build has been done, than systematically building.
To reproduce
Run yarn clean then npm pack --dry-run in a package => you will have an empty result because /dist folders are empty.
We could also simply check that all packages contain a "dist" folder or something similar.
The text was updated successfully, but these errors were encountered:
eric-burel
changed the title
Add a unit test to check built packages import
Add a test/protection to check built packages import
Jun 22, 2021
eric-burel
changed the title
Add a test/protection to check built packages import
Add a test/protection to check that NPM packages are not empty
Jun 22, 2021
A solution could be to host a very minimal app directly within vulcan-npm, so it can test whether the packages are correctly imported (in Lerna, you don't really test this because of hoisting)
Is your feature request related to a problem? Please describe.
Unit test may let pass the case where we forget to correctly export files in the NPM package.
We absolutely need to run
yarn run build
locally before publishing packages, so we need a way to secure this process.Describe the solution you'd like
We could have multiple strategies, like running
npm pack --dry-run
.We can also add a
publish
+prepublish
script that forces the build, but that can be annoying when you have already built the app and want to skip this step. I'd rather check if the build has been done, than systematically building.To reproduce
Run
yarn clean
thennpm pack --dry-run
in a package => you will have an empty result because/dist
folders are empty.We could also simply check that all packages contain a "dist" folder or something similar.
The text was updated successfully, but these errors were encountered: