Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement to mark model as serializable to be constructed by ObjectCreator #60

Open
Voiteh opened this issue Sep 6, 2018 · 0 comments
Assignees
Labels
API Change API change will be required Enhancement New feature or request P1 Priority 1

Comments

@Voiteh
Copy link
Owner

Voiteh commented Sep 6, 2018

We shouldn't be using deserializationContext as it is ment to be used when there is hierarchial dependency between not provided attributes. In our case we always have all required attributes provided. There may be problem though for selecting constructor or providing fields allready initilized so clazz.apply(....) may throw here. Further investigation will be needed. Although running unit tests in all modules should indicate problems.

@Voiteh Voiteh added Enhancement New feature or request API Change API change will be required labels Sep 6, 2018
@Voiteh Voiteh added this to the Core 0.7.0 milestone Sep 6, 2018
@Voiteh Voiteh self-assigned this Sep 6, 2018
@Voiteh Voiteh modified the milestones: Core 0.7.0, API 0.8 Sep 7, 2018
@Voiteh Voiteh removed this from the First release milestone May 3, 2019
@Voiteh Voiteh added the P1 Priority 1 label May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Change API change will be required Enhancement New feature or request P1 Priority 1
Projects
None yet
Development

No branches or pull requests

1 participant