Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULE.bazel.lock change not included in PRs #422

Open
vorburger opened this issue Mar 4, 2025 · 2 comments
Open

MODULE.bazel.lock change not included in PRs #422

vorburger opened this issue Mar 4, 2025 · 2 comments

Comments

@vorburger
Copy link
Contributor

enola-dev/enola#1175 and enola-dev/enola#1176 don't include MODULE.bazel.lock.

Should this "just work" out of the box? Or is there any configuration needed for this?

@vorburger
Copy link
Contributor Author

Perhaps this is happening when it fails to run post-update-hooks:?

I originally had some files-to-commit: GLOBs which caused fatal: pathspec 'WORKSPACE' did not match any files.

Those are now fixed, but I think it's now failing due to #424, and perhaps that's the root cause of this.

Should it perhaps be more robust and skip some of these error and still commit and proceed?

@vorburger
Copy link
Contributor Author

vorburger commented Mar 4, 2025

Perhaps this is happening when it fails to run post-update-hooks:?

Actually, no. So what happens is that when post-update-hooks: fail, then PRs just don't get pushed.

Should it perhaps be more robust and skip some of these error and still commit and proceed?

Probably not, actually; it's likely better for this to be noticed.

Those are now fixed, but I think it's now failing due to #424, and perhaps that's the root cause of this.

I've now cleaned everything up as much as possible, see e.g. this run, but the MODULE.bazel.lock is still not included in the commit & PR.

It's doing /usr/bin/git add /home/runner/work/enola/enola/MODULE.bazel but perhaps really should be doing /usr/bin/git add /home/runner/work/enola/enola/MODULE.bazel*, with a star at the end, to include the lock file?

This does seems like a bug, to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant