Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if the product name have some specific characters #38

Open
danielchicote opened this issue Mar 9, 2017 · 1 comment
Open

Error if the product name have some specific characters #38

danielchicote opened this issue Mar 9, 2017 · 1 comment

Comments

@danielchicote
Copy link

I have detected that the module don't handles correctly the product names if they have characters like "?" or "ñ" in the name. I have tried to fix it but it excess my knowledge.

@Razorphyn
Copy link

Razorphyn commented Apr 7, 2017

I haven't checked the code, since I have come across this module randomly, but I guess is problem of "allowed filename", I would rely on some proved code to check the name, like: File::Spec, since the check would be a little complicated I guess.

The most brutal way I can think of is to try to create a file with the given name(after a first regex control) and check if it exist or do not return error and in case delete it, but I think is widely open to issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants