Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does bab return 'unknown' instead of 'unsafe' when all nodes are split? #76

Open
mathisdon opened this issue Sep 13, 2024 · 0 comments

Comments

@mathisdon
Copy link

mathisdon commented Sep 13, 2024

https://github.com/Verified-Intelligence/alpha-beta-CROWN/blob/main/complete_verifier/bab.py

In bab.py, in function general_bab, there is a loop over bab "rounds" (lines 295-330). In that loop, one termination condition is that all nodes have been split, in which case it returns 'unknown'. But shouldn't that be "unsafe'?, since all nodes have been split and yet it has been unable to verify the point?

You have this code inside the loop, line 319:

    result = None
    if stats.all_node_split:
        stats.all_node_split = False
        result = 'unknown'
    elif num_domains > max_domains:
        print('Maximum number of visited domains has reached.')
        result = 'unknown'
    elif time.time() - start_time > timeout:
        print('Time out!!!!!!!!')
        result = 'unknown'
    if result:
        break
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant