Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero bytes data field and TxID calcing #1

Open
j0k opened this issue Sep 12, 2019 · 0 comments
Open

zero bytes data field and TxID calcing #1

j0k opened this issue Sep 12, 2019 · 0 comments

Comments

@j0k
Copy link

j0k commented Sep 12, 2019

what about data field?

 public static byte[] generateSignedRegularTransaction(String sourceAddress, long sourceAmount, List<Output> outputs, long signatureIndex, AddressManager addressManager) {
        if (addressManager.get(sourceAddress) == null) {
            throw new IllegalArgumentException("The address " + sourceAddress + " is not contained in the specified wallet file!");
        }

        try {
            byte[] txid = calculateRegularTransactionTxID(sourceAddress, sourceAmount, outputs, signatureIndex);
            ...
            builder.setData(ByteString.copyFrom(new byte[]{}));

code which doesn't use data: https://github.com/VeriBlock/offline-wallet-cli/blob/master/src/main/java/veriblock/OfflineTransactionUtilities.java

code which use: https://github.com/VeriBlock/alt-integration/blob/master/core/src/main/java/org/veriblock/sdk/VeriBlockTransaction.java

is it ok just to set data eq to [] without any option on that point?

@j0k j0k changed the title data field and TxID calcing zero bytes data field and TxID calcing Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant