Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text entry lag and lost keypresses on v1.26.0 #8573

Closed
agrieser opened this issue Sep 10, 2023 · 24 comments
Closed

Text entry lag and lost keypresses on v1.26.0 #8573

agrieser opened this issue Sep 10, 2023 · 24 comments

Comments

@agrieser
Copy link

Describe the bug
After updating to 1.26.0 (automatic, so it was initially quite confusing), vscode vim began eating keystrokes when typing. This is present when doing basic text entry in insert mode. For example, typing: hello world, will result in heloword or maybe hllo wrld. It is not deterministic. If I type slow enough, it seems to work.

Reverting to 1.25.2 resolves all issues.

In debugging this, I removed all of my config customization. The problem persisted on 1.26.0.

To Reproduce
Steps to reproduce the behavior:

  1. Update to 1.26.0
  2. Switch to insert mode
  3. Attempt to type
  4. Some letters are missing (eaten) from result

Steps to resolve: revert to 1.25.2

Expected behavior
Keypresses in insert mode should be preserved

Screenshots
N/A

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.26.0
  • VSCode version:1.82.0
  • OS: ChromeOS 116, arm64 5.15.117-19680-g54e910f94133
  • Device: HP chromebook x2, 8 core 8gb memory

Additional context
Happy to help debug and assist in testing on chromeOS

@Koishiiko
Copy link

+1 on Windows10

@PromethiumL
Copy link

+1 on Debian Bullseye

@julmue
Copy link

julmue commented Sep 11, 2023

+1 on Windows10

@mikavilpas
Copy link

I can confirm downgrading to v1.25.2 fixes this issue for me.

To save others some time, the downgrade can be done from the Extension: Vim screen by selecting the Install another version option:
Screenshot 2023-09-11 at 10 03 44

@joehillen
Copy link

I use Arch, BTW

@salcedo
Copy link

salcedo commented Sep 11, 2023

This is happening on Arch, BTW.
Also macOS.

@liam-murphy14
Copy link

+1 on macOS

@jabczyk
Copy link

jabczyk commented Sep 11, 2023

+1 on Win10, downgrading works for me

@davdmoo
Copy link

davdmoo commented Sep 12, 2023

+1 on windows 11. I thought my laptop was going crazy yesterday :(

@CommunityBoxDev
Copy link

+1 on Windows 10 / vscode 1.82.1 - downgrading to 1.25.2 fixes it for me ✅

@davdmoo
Copy link

davdmoo commented Sep 13, 2023

+1 on Windows 10 / vscode 1.82.1 - downgrading to 1.25.2 fixes it for me ✅

Yeah - with this and issue #8574 I'm just gonna downgrade for now.

@Mohamed-Zhran-MD
Copy link

+1 on manjaro

@loquilloll
Copy link

+1 Ubuntu 23.04

@Acrylic125
Copy link

+1 MacOS

@Fabianthorsen
Copy link

  • 1 Windows 11

@joehillen
Copy link

STOP SPAMMING YOUR OS

@salcedo
Copy link

salcedo commented Sep 14, 2023

@Fabianthorsen It doesn't appear this issue is limited to specific keyboards. I first noticed it on the Moonlander myself, which did make me first assume it had to be a configuration or driver with my keyboard. Since then, I've encountered the issue on multiple machines with different OS and VSCode versions. In each case, downgrading to 1.25.2 has resolved this.

@Acumane
Copy link

Acumane commented Sep 14, 2023

Also seeing duplication of input and chars appearing after the cursor.
e.g. something| (where | is cursor) can look like someti|ngo

@PuckCh
Copy link

PuckCh commented Sep 15, 2023

Also seeing duplication of input and chars appearing after the cursor. e.g. something| (where | is cursor) can look like someti|ngo

Same here with:

  • macOS Ventura 13.5.2
  • MacBook Pro M1
  • Moonlander keyboard, or Macbook Pro laptop keyboard directly
  • Visual Studio Code 1.82.1
  • vscodevim v1.26.0

Downgrade vscodevim remove the problem.

I suspect that the full char is not skipped, and sometime it's recognised as another key sequence, causing some (random) char inserted AFTER the cursor.

@jbsilva
Copy link

jbsilva commented Sep 15, 2023

Same here.

  • Windows 10 + WSL 2
  • VS Code 1.82.2
  • VsCodeVim 1.26.0

Downgrading to 1.25.2 works

@tudor
Copy link

tudor commented Sep 29, 2023

Same here. macOS 13.4.1, VS Code 1.82.2, VSCodeVim 1.26.0, downgrading to 1.25.2 fixed it.

This seems to happen during periods of high activity in vscode -- I'm editing C++ code with the clangd extension, and this happens a lot more as clangd is providing error / warning notifications while editing.

@tudor
Copy link

tudor commented Sep 29, 2023

Errors reported by clangd are mutating the current editor (by adding / removing error squiggles underneath pieces of code as I edit), I don't know if this is relevant or not.

@J-Fields
Copy link
Member

Should be fixed in v1.26.1

@CommunityBoxDev
Copy link

@J-Fields great news - do you know which commit fixed the issue? I had a look at the repository history for the past week or so but none of the commits stood out as the fix (apologies if I missed a very obvious commit message 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests