Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Study Access request: Per-study Verbiage changes needed to auto-emails in response to approvals #73

Open
danicahelb opened this issue Aug 3, 2023 · 4 comments
Assignees

Comments

@danicahelb
Copy link

The PERCH study team has requested that the automatic email that gets sent to the data requestor after approval contains verbiage (to be sent by Chrissy from PERCH) indicating (1) how they should acknowledge & cite PERCH and (2) that they should notify the study team in advance of all published papers or abstracts and presentations.

How can we change the verbiage of these auto-emails? Should we just hardcode this for the 8 PERCH studies?

@danicahelb
Copy link
Author

Info from @dmgaldi:

Right now, the template verbiage lives here. We'd need for there to be some optional attribute on the dataset with custom verbiage. There's not a way yet to add a study-specific message.

We could potentially hard-code it as a temporary measure if we think this is an exceptional case

@danicahelb
Copy link
Author

How much work would it be to add functionality for study specific messages? Right now we just need this for PERCH, but I wouldn’t be surprised if more studies would like this in the future. If not much work, we should make it customizable

@aurreco-uga aurreco-uga changed the title Verbiage changes needed to auto-emails in response to access request approvals Per-study Verbiage changes needed to auto-emails in response to access request approvals Aug 3, 2023
@dmfalke dmfalke transferred this issue from VEuPathDB/EdaNewIssues Aug 8, 2023
@dmgaldi
Copy link
Contributor

dmgaldi commented Aug 10, 2023

@danicahelb How would we envision this new property interacting with the default template?

Would the custom verbiage for a study be completely override the verbiage in the default template? Or could we have a part of the template that is populated by study-specific property?

The latter would be much easier for us, because we can interpolate all of the template variables once instead of having template variables nested inside other template variables.

An example of the study-specific property body would be something like:

Your request to access "$$dataset.displayName$$" data on ClinEpiDB has been approved. Navigate to the "Download" tab of "$$dataset.displayName$$" to download the data. Please cite that you accessed data via ClinEpiDB.

"$$dataset.studySpecificVerbiage$$"

Thank you!

@danicahelb
Copy link
Author

@dmgaldi part of the template can be populated by a study-specific property

@aurreco-uga please add a new prop in presenters "customApprovalEmailBody" which will be concatenated with the default verbiage in https://github.com/VEuPathDB/service-dataset-access/blob/master/src/main/resources/email.yaml

@dmgaldi dmgaldi self-assigned this Aug 11, 2023
@aurreco-uga aurreco-uga changed the title Per-study Verbiage changes needed to auto-emails in response to access request approvals study access request: Per-study Verbiage changes needed to auto-emails in response to approvals Apr 8, 2024
@aurreco-uga aurreco-uga changed the title study access request: Per-study Verbiage changes needed to auto-emails in response to approvals Study Access request: Per-study Verbiage changes needed to auto-emails in response to approvals May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants