Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo Carousel Section #92

Closed
YannickLongval opened this issue Jun 21, 2024 · 0 comments · Fixed by #109
Closed

Photo Carousel Section #92

YannickLongval opened this issue Jun 21, 2024 · 0 comments · Fixed by #109
Assignees

Comments

@YannickLongval
Copy link
Contributor

YannickLongval commented Jun 21, 2024

figma link

Add this section between about us section and the last year's statistics section

Follow the same file structure and set up as other sections

  • introduce a src/modules/photo-carousel setup with a PhotoCarousel component
  • render the component within pages/main-site/index.tsx
  • within your newly created src/modules/photo-carousel/index.tsx you can build out the section and build out components as you wish (try to follow file structure we have with other sections) i.e any extra components you build should be under the componetns folder etc

for the photos you can export them directly from figma and put them in the public folder of the repo to use / import

Also make sure it is responsive on mobile you can use the isMobile() hook to detect whether or not the screen is in mobile mode
feel free to reach out for anything

@kevinle623 kevinle623 changed the title Photo Carousel Photo Carousel Section Jun 23, 2024
@mzhang055 mzhang055 linked a pull request Jul 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants