fix: Correctly patch pdfminer to avoid unnecessarily and unsuccessfully repairing PDFs with long content streams, causing needless and endless OCR #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhdaines
changed the title
dhdaines
changed the title
|
Any update on this? |
qued
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
LGTM!
Here's what I checked:
- Ran the tests with this branch to verify that
invalid-pdf-structure-pdfminer-entire-doc.pdfis being repaired whileinvalid-pdf-structure-pdfminer-one-page.pdfis not. - Processed
invalid-pdf-structure-pdfminer-one-page.pdf(unrepaired) usingfaststrategy with the new code and looked over the results to ensure the doc is being processed properly. - Processed
invalid-pdf-structure-pdfminer-entire-doc.pdf(repaired) usingfaststrategy with the new code and looked over the results to ensure the doc is being processed properly. - Processed linked doc here with this branch and
mainbranch to verify that the doc fails before the fix and succeeds afterwards.
|
@dhdaines Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3815
Verified on my very large documents that it doesn't unnecessarily and unsuccessfully "repair" them.
You may or may not wish to keep the version check in
patch_psparser. Sinceyou're pinning the version of pdfminer.six and since it isn't guaranteed that the bug in question will be fixed in the next pdfminer.six release (but it is rather serious, so I should hope so), then perhaps you just want to unconditionally patch it.it seems like pinning of versions is only operative when running from Docker (good!) so never mind! Keep that version check!Also corrected an import so that if you do feel like using a newer version of pdfminer.six, it won't break on you.