Repo build script broken for repos with certain characters in the path

[stephenjust]

unmanic-plugins/scripts/generate_repository.py

Line 190 in 5cf3812

repo_path = configured_remote_origin.strip().rstrip(".git").lstrip('[email protected]:').lstrip('https://github.com/s')

In Python, lstrip and rstrip do not trim instances of a string, they strip characters from the provided from input. As an example, https://github.com/stephenjust/unmanic-plugins.git gets trimmed to ephenjust/unmanic-plugins (where the "st" gets chopped off because "https://github.com/" contains "s" and "t".

You probably want "removeprefix" and "removesuffix" as the most concise solution, but that requires upgrading to Python 3.9 for your Action. (This is pretty easy, but I'm not sure if you'd want inconsistency between the unmanic container running py3.8 and this build tooling running py3.9.)

[Josh5]

I'm on the fence. On the one hand, a lot of lts distros still use python 3.6/8. On the other hand who cares, i use python 3.10.

Was this not just a typo with the lstrip '.com/s'?
I can't understand why the s is there. Pretty sure that is a mistake.

At any rate, I think I'll probably merge in your fix. Thanks for the contribution!

[stephenjust]

Removing the s alone had no impact, since there was already an s in the string from https://

In terms of python, it does look like the Ubuntu LTS does have packages for newer versions (python3.9, etc), they're just not included automatically by python3.