You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking through the code on season.go and show.go for parsing the time of the seasons there is a lot of duplicate or similar code. I think could probably be put into one function, but I am unsure where this would go or if its definitely appropriate.
Failing getting MyRadio standardised in the near future, I'd like to see a (or possibly multiple) custom "time" type in myradio-go that implements the relevant (Un)marshalJSON functions, so that the *Raw members of the structs are no longer necessary.
For now though, a few lines of converting one type to another isn't a huge issue - it's just what's necessary at present
Looking through the code on season.go and show.go for parsing the time of the seasons there is a lot of duplicate or similar code. I think could probably be put into one function, but I am unsure where this would go or if its definitely appropriate.
see:
https://github.com/UniversityRadioYork/myradio-go/blob/master/show.go#L116
https://github.com/UniversityRadioYork/myradio-go/blob/master/season.go#L72
https://github.com/UniversityRadioYork/myradio-go/blob/master/season.go#L20
and maybe this too
https://github.com/UniversityRadioYork/myradio-go/blob/master/season.go#L41
The text was updated successfully, but these errors were encountered: