New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to restart through the UI can fail if state manager is completely borked #64

Open

markspolakovs opened this issue Dec 4, 2024 · 0 comments

Labels

bug

Member

markspolakovs commented Dec 4, 2024

2024-12-04 22:12:11,896  | [1113] [ERROR] Exception occurred while handling uri: 'http://studio1.ury.york.ac.uk:13500/restart'
Traceback (most recent call last):
  File "handle_request", line 100, in handle_request
  File "web_server.py", line 518, in restart
TypeError: 'NoneType' object is not subscriptable

BAPSicle/web_server.py

Lines 515 to 520 in 85f54d9

    
           if request.args.get("confirm", '') != "true": 
        
               for i in range(server_state.get()["num_channels"]): 
        
                   state = status(i) 
        
                   if state["playing"]: 
        
                       return render_template("restart-confirm.html", data=None) 
        
           server_state.update("running_state", "restarting")

Probably need some defensive checks there

The text was updated successfully, but these errors were encountered:

markspolakovs added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment