Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Request - ModalLightbox [formerly 'Carousel'] #87

Closed
jendiamond opened this issue Jun 10, 2021 · 1 comment
Closed

Component Request - ModalLightbox [formerly 'Carousel'] #87

jendiamond opened this issue Jun 10, 2021 · 1 comment

Comments

@jendiamond
Copy link
Member

jendiamond commented Jun 10, 2021

Component Description

This component is used Exhibit Details to display a carousel of images to the User.The hover states are the Prev < and Next > and X closing links. It is called Lightbox in the Figma design.

[Updated 6/25, @andrewbenedictwallace] This component should be fairly dumb, knowing only the current image / media and whether to show/enable "previous" and "next" buttons. Clicking those or the close button will emit events to the parent component (SectionGallery), which will have access to the whole list of gallery items and respond to events by updating this component with new props.

Design

Please also see attached screenshots for quick reference.

Slots

None

Props

props: {
-    items: {
-        // Mock: api.pages
-        type: Array,
-        default: () => []
-    },
+  item: {
+    // Media item to show (e.g. Image, Video)
+    type: Object,
+    required: true
+  },
+  enablePrevious: {
+    type: Boolean,
+    default: true
+  },
+  enableNext: {
+    type: Boolean,
+    default: true
+  }
}

Developer Tips

https://youtu.be/qgcdup22VRU

  1. The parent component (SectionGallery) keeps track of the full array of items and handles navigating between them. This one just displays a single item in a modal and emits events when the buttons are pressed.
  2. This is a modal
  3. We might want a child component that inspects the prop item and decides how to display it - a simple <img ...> tag for images but loading a player for AV?.
  4. Icon SVGs: Arrows and X
  5. Image
height: 883px;
width: 1441px;
left: 0px;
top: 0px;
border-radius: 0px;

Modal

width: 1441px;
height: 883px;
background: #032D5B;

Events

lightbox-select-previous
lightbox-select-next
lightbox-close

Child components

Image / Media component?

Icon SVGs

Screenshots

Screen Shot 2021-06-10 at 3 11 42 PM

@jendiamond jendiamond changed the title Component Request - {ComponentName} Component Request - Carousel Jun 10, 2021
@sourcefilter sourcefilter changed the title Component Request - Carousel Component Request - ~Carousel~ ModalFullscreenSlide Jun 25, 2021
@sourcefilter sourcefilter changed the title Component Request - ~Carousel~ ModalFullscreenSlide Component Request - Carousel [Rename to something like ModalFullscreenSlide?] Jun 25, 2021
@sourcefilter sourcefilter changed the title Component Request - Carousel [Rename to something like ModalFullscreenSlide?] Component Request - ~~Carousel~~ ModalLightbox Jun 25, 2021
@sourcefilter sourcefilter changed the title Component Request - ~~Carousel~~ ModalLightbox Component Request - ModalLightbox [formerly 'Carousel'] Jun 25, 2021
@aprigge
Copy link
Contributor

aprigge commented Nov 16, 2021

Done with #162

@aprigge aprigge closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants