Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Request - PageSection #410

Open
sourcefilter opened this issue Jun 15, 2022 · 0 comments
Open

Component Request - PageSection #410

sourcefilter opened this issue Jun 15, 2022 · 0 comments
Assignees

Comments

@sourcefilter
Copy link
Contributor

sourcefilter commented Jun 15, 2022

Component Description

Refactor the FPB components (& their children) to extract common functionality into a new

component, which handles:

  • spacing and margins
  • title and description text styling
  • alternating white and grey background
    -> should stretch across entire screen

Design

see https://www.figma.com/file/EKazRIMP4B15bD16UDbOwR/UCLA-Library-Design-System?node-id=5866%3A46501 for spacing

examples with alternating backgrounds:
https://www.figma.com/file/EKazRIMP4B15bD16UDbOwR/UCLA-Library-Design-System?node-id=5429%3A39794
https://www.figma.com/file/EKazRIMP4B15bD16UDbOwR/UCLA-Library-Design-System?node-id=4893%3A37219
https://www.figma.com/file/EKazRIMP4B15bD16UDbOwR/UCLA-Library-Design-System?node-id=717%3A15265

Slots

: Content to go inside section (likely a component like ` or )

Props

props: {
    title: {
        type: string,
        required: false,
    },
    description: {
        type: string,
        required: false,
    },
    background-color: {
        type: string,
        default: white,
    }
}

Developer Tips

maybe make background-color take a text string like 'white' or 'grey', then map it to a CSS class?

Events

none

Child components

None handled by the component (lots will go into slot though)

Screenshots

@sourcefilter sourcefilter self-assigned this Jun 15, 2022
@sourcefilter sourcefilter closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2022
@sourcefilter sourcefilter changed the title Component Request - Section Component Request - PageSection Jun 27, 2022
@sourcefilter sourcefilter reopened this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant