Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F dottween #122

Closed
laurentopia opened this issue Jan 27, 2025 · 1 comment
Closed

F dottween #122

laurentopia opened this issue Jan 27, 2025 · 1 comment

Comments

@laurentopia
Copy link

lol

Image

i don't use dottween due to perfs but ... why?

@TylerTemp
Copy link
Owner

Demigiant/dotween#251

DoTween, as a famous and popular unity package, does not follow unity package standard: no package.json and no asmdef

Without which, any 3rd party package can not provide functionality with different behavior when user has/has not DoTween installed.

Ironically, DoTween allow use to click a button called "create asmdef", which means two things: 1. DoTween can work under asmdef just fine. The author just not want to include one in the build 2. The issue has been pending for 5 years, and many PR that fixes it has been invalid with upstream, which is a huge bummer

SaintsField has a tool called "DoTweenPlay" to preview tween without entering play mode. However, because of lacking asmdef, if user has DoTween installed without manually setup a DoTween asmdef, it'll give a compile error, from SaintsField. (And might think SaintsField is broken and leave)

The script you're looking at is a standalone package (so won't be affected even when SaintsField hit the compile error), it only do one thing: if DoTween is installed without asmdef, popup a window to ask user either setup an asmdef for DoTween, or disable DoTweenPlay in SaintsField.

This small package should not depend on anything or import anything to avoid getting broken, so eveyline of that I need to manually write it in native unity editor script. I also need to copy paste some code from main SaintsField package into it...

I hate every line in it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants