Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially remove support for Ignore Extra Elements #256

Open
Turnerj opened this issue Sep 13, 2021 · 0 comments
Open

Potentially remove support for Ignore Extra Elements #256

Turnerj opened this issue Sep 13, 2021 · 0 comments
Labels
affects-serialization Serialization-related issue enhancement Enhancements & features minor-change Minor changes required
Milestone

Comments

@Turnerj
Copy link
Member

Turnerj commented Sep 13, 2021

I've been thinking about this - it might not actually be necessary to have this support. The driver requires it because of the idea that you might be overwriting things you didn't intend to. Technically though, MongoFramework does partial writes anyway so if your entity doesn't have all the fields that the collection has, it doesn't matter as only the fields you have are set.

I'd still have extra elements support in MongoFramework - that is the support to retrieve non-typed fields from the DB into your model. These would also be saved back to the DB too like normal - it is just removing the ability to ignore them because that would be the default behaviour anyway rather than an actual problem.

@Turnerj Turnerj added enhancement Enhancements & features affects-serialization Serialization-related issue minor-change Minor changes required labels Sep 13, 2021
@Turnerj Turnerj added this to the 1.0.0 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-serialization Serialization-related issue enhancement Enhancements & features minor-change Minor changes required
Projects
None yet
Development

No branches or pull requests

1 participant