From 73db952cd42b2ac1daccddf399041f3967098ae0 Mon Sep 17 00:00:00 2001
From: simonsteiger <simon.j.steiger@gmail.com>
Date: Mon, 28 Oct 2024 18:27:24 +0100
Subject: [PATCH] better link hover color

---
 theming/light.scss                  | 1 +
 theming/rules/_mixins.scss          | 1 +
 theming/rules/_navbar.scss          | 6 +++---
 theming/rules/_quarto-tweaks.scss   | 9 +++++++++
 theming/variables/_colorsdark.scss  | 5 +++--
 theming/variables/_colorslight.scss | 9 ++++-----
 6 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/theming/light.scss b/theming/light.scss
index 811650b4d..434c7a626 100644
--- a/theming/light.scss
+++ b/theming/light.scss
@@ -16,3 +16,4 @@
 
 @import "old/old-styles";
 
+//
\ No newline at end of file
diff --git a/theming/rules/_mixins.scss b/theming/rules/_mixins.scss
index 926f846a5..9eb8c54e1 100644
--- a/theming/rules/_mixins.scss
+++ b/theming/rules/_mixins.scss
@@ -36,6 +36,7 @@
     &:hover {
         background-color: $color-mute-bg !important;
         border-color: $color-mute-bg !important;
+        text-decoration: none;
     }
 }
 
diff --git a/theming/rules/_navbar.scss b/theming/rules/_navbar.scss
index ee426264e..f16f5f40f 100644
--- a/theming/rules/_navbar.scss
+++ b/theming/rules/_navbar.scss
@@ -3,15 +3,15 @@
     color: $text-muted;
 
     a:hover {
-        text-decoration: none;
+        text-decoration: none !important;
     }
 
     .nav-link:hover {
-        color: $links-hover !important;
+        color: $link-color !important;
     }
 
     .navbar-brand:hover {
-        color: $links-hover !important;
+        color: $link-color !important;
         transition: color 0.15s ease-in-out !important;
     }
 }
diff --git a/theming/rules/_quarto-tweaks.scss b/theming/rules/_quarto-tweaks.scss
index 9fa480768..f95be0518 100644
--- a/theming/rules/_quarto-tweaks.scss
+++ b/theming/rules/_quarto-tweaks.scss
@@ -25,3 +25,12 @@
 .input-group-text {
     background-color: $color-mute-bg !important;
 }
+
+a {
+    text-decoration: none;
+    &:hover {
+        color: $link-color;
+        text-decoration: underline;
+    }
+    
+}
diff --git a/theming/variables/_colorsdark.scss b/theming/variables/_colorsdark.scss
index 57cbac6e7..44fc3d24b 100644
--- a/theming/variables/_colorsdark.scss
+++ b/theming/variables/_colorsdark.scss
@@ -1,9 +1,11 @@
 $dark-green: #073c44;
 $light-blue: darken(#EDF4F4, 5%);
+$red: #f87683;
 $medium-grey: #bcbcbc;
 
 $color-primary: $light-blue; // not sure about this one
 $color-secondary: $dark-green;
+$color-tertiary: $red;
 $color-highlight: darken($color-secondary, 5%);
 
 $color-mute-bg: $gray-800;
@@ -16,8 +18,7 @@ $color-fg: white;
 $text-muted: $medium-grey;
 
 $color-active: lighten($color-secondary, 5%);
-$link-color: lighten($color-active, 30%);
-$links-hover: lighten($color-active, 30%);
+$link-color: $color-tertiary;
 $border-hover: $color-active;
 
 p {
diff --git a/theming/variables/_colorslight.scss b/theming/variables/_colorslight.scss
index e527e0931..102715630 100644
--- a/theming/variables/_colorslight.scss
+++ b/theming/variables/_colorslight.scss
@@ -1,20 +1,19 @@
 $dark-green: #073c44;
-
-$julia-green: #208921; 
+$red: #d73a4a;
 $light-blue: #EDF4F4;
 $medium-grey: #CCD1D5;
 $color-fg: black;
 
 $color-primary: $dark-green;
 $color-secondary: darken($light-blue, 20%);
+$color-tertiary: $red;
 $color-highlight: lighten($color-secondary, 10%);
 
 $color-mute-bg: $gray-200;
 
 $color-active: lighten($color-secondary, 5%);
-$link-color: $color-primary;
-$links-hover: $color-primary;
-$border-hover: $color-highlight;
+$link-color: $color-tertiary;
+$border-hover: darken($color-secondary, 5%);
 
 $body-bg: white;
 $light-bg-offset: $color-secondary;