Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Overhauled bubble particle behavior" doesn't work with soul sand bubbles #3

Open
Magicrafter13 opened this issue Jun 28, 2023 · 7 comments
Assignees
Labels
enhancement Changes for an existing feature

Comments

@Magicrafter13
Copy link

Describe the bug

Bubbles aren't going around blocks (most of the time), as shown in the demonstration video.

Steps to reproduce

Quilt 1.20.1 client, using latest version of mod on a vanilla(-compatible) server.

Expected behavior

To look like the first video on this page: https://modrinth.com/mod/make_bubbles_pop

Additional context

What it looks like on my client: https://matthewrease.net/simplescreenrecorder-2023-06-27_20.15.07.mp4 (ignore my drowning lol)

@Magicrafter13 Magicrafter13 added the bug Something isn't working label Jun 28, 2023
@Tschipcraft
Copy link
Owner

Sorry for the misconception, the overhauled bubble behavior only applies to regular bubbles particles and not the bubble particles emitting from soul sand or magma blocks. I did this, so that it doesn't appear like there is an upwards or downwards force when there is none.
In the demonstration video, I spawned the regular bubble particles by using the /particles command.

@Magicrafter13
Copy link
Author

Ah, that's unfortunate. Would it be possible to implement with soul sand, or is that just a totally different type of system?

@Tschipcraft
Copy link
Owner

No, it's the same system. I would just have to copy some code from the regular bubble particle over to the soul sand bubble particle.
I'd however like to implement this as an optional feature, so I'll first have to figure out how to use an config api mod.

@Tschipcraft Tschipcraft changed the title "Overhauled bubble particle behavior" doesn't appear to work? "Overhauled bubble particle behavior" doesn't work with soul sand bubbles Jul 4, 2023
@Tschipcraft Tschipcraft added enhancement Changes for an existing feature and removed bug Something isn't working labels Jul 6, 2023
@Magicrafter13
Copy link
Author

To throw my two cents into the ring, Mod Menu integration would probably be the best route for config.

@Tschipcraft
Copy link
Owner

Yes, that's for sure. I'm currently experimenting with MidnightLib and got basic configuration working.

@Tschipcraft Tschipcraft self-assigned this Feb 17, 2024
@HB-Stratos
Copy link

just ran into this, would be cool to see this implemented still.

@Tschipcraft
Copy link
Owner

This is still in development, I plan on adding functionality for the bubbles to switch between their types (normal, soul sand, magma) based on their location before adding this. It will probably be in v0.4.0 or smth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes for an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants