Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add support for creating poster by spotify album/track url only #32

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alanoy
Copy link

@alanoy alanoy commented Jan 13, 2025

Closes #29

@alanoy alanoy marked this pull request as ready for review January 13, 2025 02:45
@TrueMyst
Copy link
Owner

The code isn't ready at all. It is poorly documented. Second of all, get_track & get_album should accept the url itself. There are other things, which not worth mentioning.

@alanoy
Copy link
Author

alanoy commented Jan 14, 2025

Thanks for the feedback. I understand the concerns about code quality and functionality. I will make a refactoring.

@alanoy
Copy link
Author

alanoy commented Jan 14, 2025

The code isn't ready at all. It is poorly documented. Second of all, get_track & get_album should accept the url itself. There are other things, which not worth mentioning.

I have pushed new commits. Please take a look and let me know if further changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add ID-based Metadata Retrieval for Tracks and Albums
2 participants