Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS classes #537

Open
davinov opened this issue May 13, 2020 · 0 comments
Open

CSS classes #537

davinov opened this issue May 13, 2020 · 0 comments
Labels
convention

Comments

@davinov
Copy link
Member

davinov commented May 13, 2020

In step forms, I noticed no fixed convention for CSS classes.
In other ToucanToco projects, we use BEM classes. It avoids confusion and name collision.

I suggest we apply the same convention here.

Example: https://github.com/ToucanToco/weaverbird/pull/536/files/5f1aa614674951c2cd08bc95480ef47966f2370d#diff-17991a7509024f08f53d766e0459330eR14
class="formulaInput" to class="formula-step-form__formula"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
convention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davinov