Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider should take string and parent instead of QLabel #60

Closed
lauramurgatroyd opened this issue Jan 9, 2023 · 2 comments
Closed

Slider should take string and parent instead of QLabel #60

lauramurgatroyd opened this issue Jan 9, 2023 · 2 comments

Comments

@lauramurgatroyd
Copy link
Member

https://github.com/paskino/qt-elements/blob/main/eqt/ui/UISliderWidget.py

@jcornall
Copy link
Collaborator

jcornall commented Dec 17, 2024

After reviewing pull request #168, it was determined that including a parent parameter in the UISliderWidget's __init__() method would be redundant - this is because the parent() attribute is implicitly set to None when the UISliderWidget is instantiated, and is updated to the FormDialog object when the addWidget() method is called. Because the parent does not need to be explicitly set, this parameter is not required.

@lauramurgatroyd
Copy link
Member Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants